Add stream-key auto-conversion for ByteRecord #3204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add automatic type conversion logic in StreamRecords.ofBytes() method to handle different stream key types safely. This resolves the TODO comment and prevents ClassCastException when using String or ByteBuffer stream keys without RedisTemplate. Supported conversions: - String to byte[] using UTF-8 encoding - ByteBuffer to byte[] by copying buffer contents - byte[] passed through unchanged - null values handled gracefully - Unsupported types throw IllegalArgumentException with clear message The implementation follows the same pattern as the existing ofBuffer() method for consistency. This improvement enhances developer experience when working directly with Redis connections instead of RedisTemplate, particularly useful for performance-critical scenarios or custom serialization requirements. Added comprehensive test coverage including edge cases and error handling to ensure robust behavior across all supported input types. Signed-off-by: Seo Bo Gyeong <dodu7510@gmail.com>
7bcc594 to
acc8ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automatic type conversion logic in StreamRecords.ofBytes() method to handle different stream key types safely. This resolves the TODO comment and prevents ClassCastException when using String or ByteBuffer stream keys without RedisTemplate.
Supported conversions:
The implementation follows the same pattern as the existing ofBuffer() method for consistency. This improvement enhances developer experience when working directly with Redis connections instead of RedisTemplate, particularly useful for performance-critical scenarios or custom serialization requirements.
Added comprehensive test coverage including edge cases and error handling to ensure robust behavior across all supported input types.