-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Allow non-integer RANGE in OVER #12695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Allow non-integer RANGE in OVER #12695
Conversation
Hi, Given a quick glance, it looks ok, thanks. |
places were we could use a test:
|
00afd4f
to
a779c37
Compare
Added in 00afd4f. Some problems I noticed:
|
Any input on my comments above? Alternatively, what do you all think about merging the changes as-is to at least handle fractional numeric values? |
sorry, haven't had time to re-look at this. I'll make it run the full ci at least |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision a779c37 of this pull request into gerrit so we can run tests and reviews and stuff
New Gerrit review created for change a779c37: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 897929e of this pull request into gerrit so we can run tests and reviews and stuff
Patchset 897929e added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision c373341 of this pull request into gerrit so we can run tests and reviews and stuff
Patchset c373341 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very good but needs a change in the test suite, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 794e265 of this pull request into gerrit so we can run tests and reviews and stuff
Patchset 794e265 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision baa70bf of this pull request into gerrit so we can run tests and reviews and stuff
Patchset baa70bf added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 1bc7261 of this pull request into gerrit so we can run tests and reviews and stuff
Patchset 1bc7261 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6022 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 8063cec of this pull request into gerrit so we can run tests and reviews and stuff
Patchset 8063cec added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6022 |
Description
Fixes #12596.
This PR attempts to implement the solution described here, though there are some small differences since the version I was looking at there is 1.4, and this PR is for 2.0. I tried to update the tests to account for the changes, and was seeing them pass locally.
Let me know if there's anything I missed, and as always thanks for all your hard work.
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit messageHave a nice day!