Skip to content

type pysqlite #12789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

type pysqlite #12789

wants to merge 4 commits into from

Conversation

Polandia94
Copy link
Contributor

type pysqlite from dialects.
type some related code on pysqlite.py

related to #6810

Description

Checklist

This pull request is:

  • A documentation / typographical / small typing error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

@CaselIT CaselIT requested a review from sqla-tester August 7, 2025 12:52
sqla-tester
sqla-tester reviewed Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 0535cee of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change 0535cee: https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6082

@Polandia94
Copy link
Contributor Author

I merge main to resolve conflicts, also changed dbapi_connection to dbapi_conn, becuase that is the name in the superclass engine.interfaces.Dialect

@CaselIT CaselIT requested a review from sqla-tester August 23, 2025 12:33
sqla-tester
sqla-tester reviewed Aug 23, 2025
View reviewed changes
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 2c1ea72 of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

Patchset 2c1ea72 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/sqlalchemy/+/6082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sqla-tester sqla-tester sqla-tester left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Polandia94 @sqla-tester