feat: implement $ARGUMENTS indexing and splitting for /commands
#2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for $ARGUMENTS[n] single index access - Add support for $ARGUMENTS[n*] all-from-index pattern - Add support for $ARGUMENTS[n+] adjacent arguments pattern - Add support for $ARGUMENTS[n++] three-argument pattern - Add support for $ARGUMENTS[n:m] range selection pattern - Update command documentation with comprehensive examples - Maintain backward compatibility with existing $ARGUMENTS usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds powerful new argument handling capabilities for custom commands, making them more flexible for complex workflows.
New Features
Argument Patterns:
$ARGUMENTS[n]- Single argument at index n$ARGUMENTS[n*]- All arguments from index n onwards$ARGUMENTS[n+]- Arguments at index n and n+1$ARGUMENTS[n++]- Arguments at index n, n+1, and n+2$ARGUMENTS[n:m]- Range from index n to mExample
With "/hello hello world foo bar baz . -y"
$ARGUMENTS[0] → "hello"
$ARGUMENTS[1*] → "world foo bar baz . -y"
$ARGUMENTS[2+] → "foo bar"
$ARGUMENTS[3++] → "bar baz ."
$ARGUMENTS[1:4] → "world foo bar baz"
The implementation handles out-of-bounds indices gracefully