Skip to content

🍒 [lldb][windows] use Windows APIs to print to the console (#149493) #11219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: swift/release/6.2.0
Choose a base branch
from
Open

🍒 [lldb][windows] use Windows APIs to print to the console (#149493) #11219

wants to merge 1 commit into from

Conversation

charles-zablit
Copy link

@charles-zablit
[lldb][windows] use Windows APIs to print to the console (llvm#149493)
ab3bf80 
This patch uses the Windows APIs to print to the Windows Console,
through `llvm::raw_fd_ostream`.

This fixes a rendering issue where the characters defined in
`DiagnosticsRendering.cpp` (`"╰"` for instance) are not rendered
properly on Windows out of the box, because the default codepage is not
`utf-8`.

This solution is based on [this patch
downstream](https://github.com/swiftlang/swift/pull/40632/files#diff-e948e4bd7a601e3ca82d596058ccb39326459a4751470eec4d393adeaf516977R37-R38).

rdar://156064500
@charles-zablit charles-zablit requested a review from a team as a code owner August 19, 2025 14:10
@charles-zablit
Copy link
Author

@swift-ci please test

@charles-zablit charles-zablit self-assigned this Aug 19, 2025
@charles-zablit
Copy link
Author

Let's wait until llvm#149493 (comment) is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael137 Michael137 Michael137 approved these changes

@adrian-prantl adrian-prantl Awaiting requested review from adrian-prantl

At least 1 approving review is required to merge this pull request.

Assignees

@charles-zablit charles-zablit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charles-zablit @Michael137