Skip to content

[lldb] Fix regression in 32-bit String data formatter #11268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
+14 −10
Merged

[lldb] Fix regression in 32-bit String data formatter #11268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions lldb/source/Plugins/Language/Swift/SwiftFormatters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,19 +219,23 @@ static bool makeStringGutsSummary(
llvm::StringRef variantCase = variant_sp->GetValueAsCString();

ValueObjectSP payload_sp;
if (variantCase.starts_with("immortal")) {
payload_sp = variant_sp->GetChildAtNamePath({g_immortal, g__value});
} else if (variantCase.starts_with("native")) {
payload_sp = variant_sp->GetChildAtNamePath({g_immortal, g__value});
} else if (variantCase.starts_with("bridged")) {
static ConstString g_bridged("bridged");
auto anyobject_sp = variant_sp->GetChildMemberWithName(g_bridged, true);
if (!anyobject_sp)
return error("unexpected layout (bridged)");
payload_sp = anyobject_sp->GetChildAtIndex(0, true); // "instance"
if (variantCase == "immortal" || variantCase == "native" ||
variantCase == "bridged") {
payload_sp = variant_sp->GetSyntheticValue();
if (!payload_sp)
return error("unexpected layout (no variant)");
payload_sp = payload_sp->GetChildAtIndex(0);
if (!payload_sp)
return error("unexpected layout (no variant payload)");
payload_sp = payload_sp->GetSyntheticValue();
} else {
return error("unknown variant");
}
if (variantCase == "bridged") {
if (!payload_sp)
return error("unexpected layout (bridged)");
payload_sp = payload_sp->GetChildAtIndex(0, true); // "instance"
}
if (!payload_sp)
return error("no payload");

Expand Down