Skip to content

Remove some obsolete properties from the macOS ToolchainInfo.plist #83274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

Remove some obsolete properties from the macOS ToolchainInfo.plist #83274

merged 1 commit into from
Aug 25, 2025

Conversation

jakepetroules
Copy link
Contributor

  • CompatibilityVersionDisplayString isn't required and it's misleading to write Xcode 8 here, which is far below the actual compatibility
  • ENABLE_BITCODE is now ignored by Swift Build
  • SWIFT_DISABLE_REQUIRED_ARCLITE is now ignored by Swift Build
  • SWIFT_LINK_OBJC_RUNTIME doesn't need to be set as it's already set to an appropriate per-platform default

@jakepetroules
Remove some obsolete properties from the macOS ToolchainInfo.plist
a4f41ba 
- CompatibilityVersionDisplayString isn't required and it's misleading to write Xcode 8 here, which is far below the actual compatibility
- ENABLE_BITCODE is now ignored by Swift Build
- SWIFT_DISABLE_REQUIRED_ARCLITE is now ignored by Swift Build
- SWIFT_LINK_OBJC_RUNTIME doesn't need to be set as it's already set to an appropriate per-platform default
@jakepetroules jakepetroules requested a review from shahmishal July 23, 2025 23:54
@jakepetroules
Copy link
Contributor Author

@swift-ci test

@etcwilde
Copy link
Member

We should run a toolchain build just to be sure, but this looks fine to me.

@etcwilde
Copy link
Member

@swift-ci Please Build Toolchain macOS Platform

@jakepetroules jakepetroules merged commit b2ad483 into swiftlang:main Aug 25, 2025
6 checks passed
@jakepetroules jakepetroules deleted the eng/PR-obsolete-props branch August 25, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde etcwilde approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakepetroules @etcwilde