ComputeSideEffects: compute properties even if function has an effect attribute #83665
+231
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
reviewed
Aug 12, 2025
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
|
The 1 test failure on the macOS platform doesn't seem to be related to this change (WatchOS version issues), so it should be ok to merge anyway. |
|
@swift-ci test macos |
81d6e8b to
8771877
Compare
|
@swift-ci apple silicon benchmark |
1 similar comment
|
@swift-ci apple silicon benchmark |
|
@swift-ci apple silicon benchmark |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
|
@swift-ci apple silicon benchmark |
|
@swift-ci test |
7bb2a3c to
aae3944
Compare
|
@swift-ci smoke test macOS |
|
@swift-ci smoke test linux |
|
@swift-ci smoke test macOS |
56c78c6 to
8897903
Compare
|
@swift-ci smoke test |
|
@swift-ci apple silicon benchmark |
eeckstein
reviewed
Aug 22, 2025
SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ComputeSideEffects.swift
Outdated
Show resolved
Hide resolved
After computing side effects, we also remove any global or argument effects that are computed to happen, but are defined not to, based on the effect attribute. This allows us to compute the deinit_barrier effect for such functions, fixing the test case here: rdar://155870190 This supercedes swiftlang#38324.
8897903 to
6a263f8
Compare
|
@swift-ci smoke test |
|
@swift-ci test windows |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the compute-side-effects pass does nothing if a function has an effect attribute. This prevents certain optimisations, such as temporary lvalue elimination, from working for callers of such functions.
This is a naive fix, which will worsen the performance of the compute-side-effects pass by making it run of functions it wouldn't have otherwise.
For the test case this patch aims to fix, we only need to compute the isDeinitBarrier property. We could attempt to only store that property, but there is no benefit to this over storing all the computed side effect properties. The benefit of the previous behaviour was avoiding the overhead of computing any properties in the first place.
rdar://155870190
This aims to resolve the same problem as #38324.