🍒[cxx-interop] Prohibit weak references to foreign reference types #83804
+36
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a runtime crash when a `weak` reference to a C++ foreign reference type is used. Instead of a runtime crash, Swift would now emit a compiler error saying that `weak` keyword is incompatible with foreign reference types. rdar://124040825 / resolves swiftlang#83080 (cherry picked from commit 9abadf5)
|
@swift-ci please test |
Xazax-hun
approved these changes
Aug 19, 2025
DougGregor
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weakreference to a C++ foreign reference type is used. Instead of a runtime crash, Swift would now emit a compiler error saying thatweakkeyword is incompatible with foreign reference types.weakreferences to foreign reference types.