Skip to content

Conversation

eeckstein
Copy link
Contributor

@eeckstein eeckstein commented Aug 26, 2025

  1. In MandatoryPerformanceOptimization: this is required for embedded swift.
  2. In the DeinitDevirtualizer: for performance

This PR also reverts the workaround of #83906

Fixes a crash in IRGen
rdar://157131184

@eeckstein eeckstein force-pushed the fix-deinit-devirtualization-for-arrays branch from 973640b to 06a81d1 Compare August 26, 2025 19:30
@eeckstein eeckstein changed the title MandatoryPerformanceOptimization: de-virtualize deinits of builtin "destroyArray" Optimizer: de-virtualize deinits of builtin "destroyArray" Aug 26, 2025
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein eeckstein requested review from atrick, meg-gupta, nate-chandler, aidan-hall and DougGregor and removed request for rjmccall August 26, 2025 19:33
Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eeckstein eeckstein force-pushed the fix-deinit-devirtualization-for-arrays branch from 06a81d1 to 8e33487 Compare August 28, 2025 06:05
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein
Copy link
Contributor Author

@swift-ci benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants