Adopt typed throws in withUnsafeTemporaryAllocation #83921
Merged
+105
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interior wrapping in Result<T, U> is a little unfortunate, but is currently necessary because we end up with extra stack allocations along the error-handling path in a do..catch that aren't there when using untyped throws. We can simplify the implementation if we can eliminate the extraneous stack allocation. Fixes rdar://134973620.
|
@swift-ci please smoke test |
tshortli
reviewed
Aug 26, 2025
glessard
approved these changes
Aug 26, 2025
glessard
reviewed
Aug 26, 2025
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interior wrapping in Result<T, U> is a little unfortunate, but is currently necessary because we end up with extra stack allocations along the error-handling path in a do..catch that aren't there when using untyped throws. We can simplify the implementation if we can eliminate the extraneous stack allocation.
Fixes rdar://134973620.