Sema: Diagnose key paths when MemberImportVisibility is enabled
#83934
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
tshortli
added a commit
to tshortli/sourcekit-lsp
that referenced
this pull request
Aug 27, 2025
With the Swift compiler fix swiftlang/swift#83934 (which ensures that key paths are diagnosed correctly when `MemberImportVisibility` is enabled) SourceKit no longer builds because the compiler now correctly identifies a missing import of `SourceKitD`. Add the missing import.
The diagnostic pass that checks whether expressions reference member declarations that have not been imported failed to handle key path expressions. Resolves rdar://159093481.
36a85b0 to
ea714d2
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagnostic pass that checks whether expressions reference member declarations that have not been imported failed to handle key path expressions.
Resolves rdar://159093481.