[cxx-interop] Import functions that return auto
#83949
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Swift would not import such C++ functions. rdar://159282319
|
@swift-ci please smoke test |
j-hui
approved these changes
Aug 27, 2025
Xazax-hun
approved these changes
Aug 27, 2025
| @@ -2382,6 +2382,12 @@ ImportedType ClangImporter::Implementation::importFunctionParamsAndReturnType( | |||
| bool allowNSUIntegerAsInt = | |||
| shouldAllowNSUIntegerAsInt(isFromSystemModule, clangDecl); | |||
|
|
|||
| // If this function uses 'auto' return type, try to deduce the actual type. | |||
| if (clangDecl->getReturnType()->isUndeducedType()) | |||
| getClangSema().DeduceReturnType( | |||
There was a problem hiding this comment.
I wonder if this could make some template instantiations more eager (as we already have the overly eager instantiation problem).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Swift would not import such C++ functions.
rdar://159282319