[Concurrency] Updates after second SE pitch. #83950
Open
+1,160
−293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer attempt to convert timestamps from the passed-in `Clock` in order to allow any clock to work with any executor. Instead, executors that do not recognise a clock should call the `enqueue` function on that `Clock`, which lets the `Clock` itself decide how to proceed. Additionally, rename `SchedulableExecutor` to `SchedulingExecutor`.
This makes the custom global executor support and associated functionality public.
|
Explanation: This is a cherry pick of #82456, but with everything still non-public, along with a separate commit to make all the new functionality public, so that we can easily revert the latter and leave ourselves in a position where 6.2 is unchanged. |
|
@swift-ci Please test |
|
@swift-ci Please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer attempt to convert timestamps from the passed-in
Clockin order to allow any clock to work with any executor. Instead, executors that do not recognise a clock should call theenqueuefunction on thatClock, which lets theClockitself decide how to proceed.Also, make all the new functionality public on the 6.2 branch (it's currently private).