[cmake] Use correct identifier for CFBundleIdentifier #83960
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
reviewed
Aug 27, 2025
| @@ -158,5 +158,5 @@ emit_swift_interface(swift_Concurrency) | |||
| install_swift_interface(swift_Concurrency) | |||
|
|
|||
| # Configure plist creation for Darwin platforms. | |||
| generate_plist("${CMAKE_PROJECT_NAME}" "${CMAKE_PROJECT_VERSION}" swift_Concurrency) | |||
| generate_plist(swiftConcurrency swift_Concurrency"${CMAKE_PROJECT_VERSION}" swift_Concurrency) | |||
There was a problem hiding this comment.
Suggested change
| generate_plist(swiftConcurrency swift_Concurrency"${CMAKE_PROJECT_VERSION}" swift_Concurrency) | |
| generate_plist(swiftConcurrency swift_Concurrency "${CMAKE_PROJECT_VERSION}" swift_Concurrency) |
0ae1a98 to
a9ab210
Compare
|
@swift-ci smoke test |
edymtt
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the associated library name for the
CFBundleIdentifierwithin the plist. This will prevent cases where we have projects with multiple targets referencing the project name itself (i.e swiftSwiftOnoneSupport had it's bundle name set to SwiftCore)