[Store] Add Milvus #314
[Store] Add Milvus #314
Conversation
a54cdd5 to
40ad9dc
Compare
|
Needs a rebase after #317 |
There was a problem hiding this comment.
Alright, I played a little bit around with it and also running Milvus on cloud.zilliz.com.
On thing, that made it harder for me is the database - this is not actually needed. With the cloud service i ran into 403, but worked when commenting it out - and also locally it works without creating the database first.
I think the database should at least be optional - maybe if database is not null or something?
|
Ah yes, tested the cloud version and it comes with an existing database, hum, one solution might be to add a |
40ad9dc to
af904c0
Compare
|
Small update here @chr-hertel @OskarStark, I removed the |
6714ec0 to
ad99e8d
Compare
|
I just rebased the branch against |
ad99e8d to
c0d955f
Compare
|
Thank you @Guikingone. |
This PR was squashed before being merged into the main branch. Discussion ---------- [Store] Add ManagedStoreInterface | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Docs? | yes | Issues | #285 #314 | License | MIT Hi 👋🏻 This PR aim to introduce the `ManagedStoreInterface` as discussed in #285, `Store` is a critical part of this library so I'm not gonna pretend that I know how each store currently work but here's the refactoring for most of them, tests must be improved but here's the first "draft". This PR does not include the related commands. Commits ------- 35aec00 [Store] Add ManagedStoreInterface
Hi 👋🏻
This PR aim to add the support for
Milvusin theStorecomponent, it also introduce aDroppableStoreInterfacethat allows to remove the current database (because it's boring to remove the volumes and drop the services from Docker 😄 ).Thanks for the feedback.