bug #61031 [HttpClient] return early if handle has been cleaned up before (xabbuh)

fabpot · fabpot · commit 60623b640a61 · 2025-07-04T08:09:28.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- [HttpClient] return early if handle has been cleaned up before | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT When a request has been cleaned up by the PHP process there still can be an event that will later on try to generate the response. Previously this lead to a warning like `Undefined array key "bg"`. spotted in #58370 where this makes the test fail with PHPUnit 11.5: https://github.com/symfony/symfony/actions/runs/16051022174/job/45293445147#step:9:3827 Commits ------- fb4711b return early if handle has been cleaned up before
diff --git a/src/Symfony/Component/HttpClient/Response/AmpResponseV5.php b/src/Symfony/Component/HttpClient/Response/AmpResponseV5.php
@@ -240,6 +240,10 @@ private static function generateResponse(Request $request, AmpClientStateV5 $mul
             $body = $response->getBody();
 
             while (true) {
+                if (!isset($multi->openHandles[$id])) {
+                    return;
+                }
+
                 $multi->openHandles[$id]->complete();
                 $multi->openHandles[$id] = new DeferredFuture();
 
