-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
run tests using PHPUnit 11.5 #58370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.4
Are you sure you want to change the base?
run tests using PHPUnit 11.5 #58370
Conversation
The PR cannot be merged at the moment as it is based on a bunch of other open pull requests that are paving the way to be able to actually run the tests with PHPUnit 11. |
7178ae5
to
76245c5
Compare
This is super nice news! Did you already take care of everything required to be "PHPUnit 11 compliant" in already opened PRs ? |
@alexandre-daubois The "ensure session storages are opened before destroying them" commit is the only one that is not already part of an open PR. I do not really understand yet why that change is necessary (the flow in |
76245c5
to
24d86e8
Compare
This PR was merged into the 5.4 branch. Discussion ---------- Tweak error/exception handler registration | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53812 | License | MIT This should allow removing the custom bootstrap file from #58370 /cc `@xabbuh` The change on FrameworkBundle leads to a tweaked behavior: we don't override the previous error handler in case it's not the Symfony one. This shouldn't change anything in practice since the error handler is already registered by the runtime component. The rest is closer to bug fixes. Commits ------- af9c035 Tweak error/exception handler registration
We need a way to register DebugClassLoader, and maybe a few other things. Basically what we do in SymfonyTestsListenerTrait. |
ab2f604
to
e56f932
Compare
e56f932
to
bddc3f5
Compare
d72eadc
to
c89477a
Compare
@@ -30,7 +30,7 @@ | |||
"symfony/dependency-injection": "^6.4|^7.0", | |||
"symfony/doctrine-messenger": "^6.4|^7.0", | |||
"symfony/expression-language": "^6.4|^7.0", | |||
"symfony/form": "^6.4.6|^7.0.6", | |||
"symfony/form": "^7.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we need #58357
This PR was merged into the 7.3 branch. Discussion ---------- [Translation] drop support for nikic/php-parser 4 | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Extracted from #58370, background: PHPUnit 11 is no longer compatible with `nikic/php-parser` 4 (see #58370 (comment)). Commits ------- 2676ce9 drop support for nikic/php-parser 4
890b854
to
8f0b304
Compare
cb7741d
to
84443c0
Compare
This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] make data provider static | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT spotted in #58370 (I missed this in #60365) Commits ------- 04a46d3 make data provider static
cfa0923
to
8a20f9f
Compare
8a20f9f
to
7296609
Compare
a440ba5
to
1063ab5
Compare
5e4fdba
to
ae5c4c9
Compare
ae5c4c9
to
0d5643d
Compare
c74b7ad
to
1f1acda
Compare
1f1acda
to
fb2eb1c
Compare
Uh oh!
There was an error while loading. Please reload this page.