Skip to content

run tests using PHPUnit 11.5 #58370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 7.4
Choose a base branch
from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 24, 2024

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh
Copy link
Member Author

xabbuh commented Sep 24, 2024

The PR cannot be merged at the moment as it is based on a bunch of other open pull requests that are paving the way to be able to actually run the tests with PHPUnit 11.

@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 2 times, most recently from 7178ae5 to 76245c5 Compare September 24, 2024 07:31
@alexandre-daubois
Copy link
Member

This is super nice news! Did you already take care of everything required to be "PHPUnit 11 compliant" in already opened PRs ?

@xabbuh
Copy link
Member Author

xabbuh commented Sep 24, 2024

@alexandre-daubois The "ensure session storages are opened before destroying them" commit is the only one that is not already part of an open PR. I do not really understand yet why that change is necessary (the flow in AbstractSessionHandler is different as headers_sent() returns a different result).

@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch from 76245c5 to 24d86e8 Compare September 24, 2024 11:18
@xabbuh xabbuh requested a review from chalasr as a code owner September 24, 2024 11:18
nicolas-grekas added a commit that referenced this pull request Sep 25, 2024
This PR was merged into the 5.4 branch.

Discussion
----------

Tweak error/exception handler registration

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #53812
| License       | MIT

This should allow removing the custom bootstrap file from #58370 /cc `@xabbuh`

The change on FrameworkBundle leads to a tweaked behavior: we don't override the previous error handler in case it's not the Symfony one. This shouldn't change anything in practice since the error handler is already registered by the runtime component.

The rest is closer to bug fixes.

Commits
-------

af9c035 Tweak error/exception handler registration
@nicolas-grekas
Copy link
Member

We need a way to register DebugClassLoader, and maybe a few other things. Basically what we do in SymfonyTestsListenerTrait.

@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 2 times, most recently from ab2f604 to e56f932 Compare September 25, 2024 16:42
@xabbuh xabbuh changed the title run integration tests using PHPUnit 11 [WIP] run integration tests using PHPUnit 11 Sep 27, 2024
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch from e56f932 to bddc3f5 Compare September 27, 2024 11:30
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 5 times, most recently from d72eadc to c89477a Compare October 10, 2024 06:49
@xabbuh xabbuh changed the title [WIP] run integration tests using PHPUnit 11 run integration tests using PHPUnit 11 Oct 10, 2024
@xabbuh xabbuh changed the title run integration tests using PHPUnit 11 [WIP] run integration tests using PHPUnit 11 Oct 10, 2024
@@ -30,7 +30,7 @@
"symfony/dependency-injection": "^6.4|^7.0",
"symfony/doctrine-messenger": "^6.4|^7.0",
"symfony/expression-language": "^6.4|^7.0",
"symfony/form": "^6.4.6|^7.0.6",
"symfony/form": "^7.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we need #58357

fabpot added a commit that referenced this pull request Apr 23, 2025
This PR was merged into the 7.3 branch.

Discussion
----------

[Translation] drop support for nikic/php-parser 4

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

Extracted from #58370, background: PHPUnit 11 is no longer compatible with `nikic/php-parser` 4 (see #58370 (comment)).

Commits
-------

2676ce9 drop support for nikic/php-parser 4
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 3 times, most recently from 890b854 to 8f0b304 Compare April 24, 2025 19:19
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 2 times, most recently from cb7741d to 84443c0 Compare May 8, 2025 13:25
xabbuh added a commit that referenced this pull request May 8, 2025
This PR was merged into the 6.4 branch.

Discussion
----------

[FrameworkBundle] make data provider static

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

spotted in #58370 (I missed this in #60365)

Commits
-------

04a46d3 make data provider static
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 2 times, most recently from cfa0923 to 8a20f9f Compare May 13, 2025 08:01
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch from 8a20f9f to 7296609 Compare May 26, 2025 06:06
@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 3 times, most recently from a440ba5 to 1063ab5 Compare May 30, 2025 22:15
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 2 times, most recently from 5e4fdba to ae5c4c9 Compare June 3, 2025 06:22
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch from ae5c4c9 to 0d5643d Compare June 14, 2025 19:49
@xabbuh xabbuh force-pushed the phpunit11-integration-tests branch 3 times, most recently from c74b7ad to 1f1acda Compare June 14, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants