Symfony version(s) affected

6.4

Description

The implementation of RegionDataGenerator has different standards for different data sets from ICU's data import. This results in inconsistent lists between

• Regions
• Alpha2ToAlpha3
• Alpha3ToAlpha2
• NumericToAlpha2

Regions

This is the first of the data sets to be pulled from ICU, it is in the end a translated list of Alpha2 country codes from localeBundle['Countries']. This is quiet good and does filter out certain code in the components's DENYLIST.

Alpha2ToAlpha3

This is the next data set that is pulled from ICU (via $metadataBundle['alias']['territory']) but filtered against Regions from above.

Alpha3ToAlpha2

The next data set. It is a simple array flip of Alpha3ToAlpha2, which makes it also filtered against Regions.

NumericToAlpha2

The last data set that is directly pulled from ICU (via $metadataBundle['alias']['territory']) but this time not filtered against Regions. This is turns makes it so that when using Countries and interacting with numeric lists, the following extra codes are available for usage (but not in the other 3 data sets):

How to reproduce

Install the Intl component and simply dump the following data:

var_dump(Countries::getNumericCodes());

Possible Solution

The solution is to change the signature of the private function generateAlpha2ToNumericMapping so it is in line with the other functions that filter "territories" data against Regions (see above).

class RegionDataGenerator extends AbstractDataGenerator
{
    // ...
    private function generateAlpha2ToAlpha3Mapping(array $countries, ArrayAccessibleResourceBundle $metadataBundle): array
    {
        // ...
    }

    private function generateAlpha2ToNumericMapping(ArrayAccessibleResourceBundle $metadataBundle): array
    {
        // ...
    }
}

becomes

class RegionDataGenerator extends AbstractDataGenerator
{
    // ...
   private function generateAlpha2ToNumericMapping(array $countries, ArrayAccessibleResourceBundle $metadataBundle): array
    {
        // now check against countries and ignore codes reserved for the future or for private use
    }
}

My main question is if this is considered a BC break or not? I have the code to "fix" this ready, but I am not sure if it should go to Symfony 6.4, 7.4 or even 8.0?

Additional Context

No response