[BrowserKit] Fix doc about submitForm behaviour
#60264
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
c4b739a to
6776dc4
Compare
6776dc4 to
8ddefb3
Compare
This PR was merged into the 6.4 branch. Discussion ---------- [BrowserKit] Fix `submitForm` behaviour See symfony/symfony#60264 Commits ------- ce4cd4d [BrowserKit] Fix `submitForm` behaviour
|
It's a bit more complex than that i'm afraid. It does look for You can check with a test like this: public function testSubmitFormWithInputSubmitValue()
{
$client = $this->getBrowser();
$client->setNextResponse(new Response('<html><form action="/foo"><input type="submit" value="the_value" /></form></html>'));
$client->request('GET', 'http://www.example.com/foo/foobar');
$client->submitForm('the_value');
$this->assertSame('http://www.example.com/foo', $client->getRequest()->getUri(), '->submit() submit forms');
} |
|
@smnandre this means we should close this PR, isn't it? |
|
I think so, but something could maybe be clarified in the doc |
See #58509 (comment)