Skip to content

[Validator] Review Latvian translations #60414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

Conversation

laurisb
Copy link
Contributor

@laurisb laurisb commented May 13, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59421
License MIT

Translated keys: 120, 121

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@@ -468,11 +468,11 @@
</trans-unit>
<trans-unit id="120">
<source>This value is not a valid slug.</source>
<target state="needs-review-translation">Šī vērtība nav derīgs slug.</target>
<target>Šī vērtība nav derīgs URL fragments.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A URL fragment is not the same as a slug. Why not keep slug here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, reverted. We have a word for path but not for a slug: https://lv.wikipedia.org/wiki/Vienotais_resursu_vietr%C4%81dis

@nicolas-grekas
Copy link
Member

Thank you @laurisb.

@nicolas-grekas nicolas-grekas merged commit ca85f5f into symfony:6.4 May 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants