[ObjectMapper] embed collection transformer #60442
Open
+103
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
May 17, 2025
GromNaN
reviewed
May 19, 2025
Comment on lines
+54
to
+57
| use Symfony\Component\ObjectMapper\Tests\Fixtures\TransformCollection\A as TransformCollectionA; | ||
| use Symfony\Component\ObjectMapper\Tests\Fixtures\TransformCollection\B as TransformCollectionB; | ||
| use Symfony\Component\ObjectMapper\Tests\Fixtures\TransformCollection\C as TransformCollectionC; | ||
| use Symfony\Component\ObjectMapper\Tests\Fixtures\TransformCollection\D as TransformCollectionD; |
There was a problem hiding this comment.
I would make the classe names longer instead of using an alias. It's simpler to call the class by its name.
There was a problem hiding this comment.
its nitpicking as these are test fixtures I don't see the benefits
src/Symfony/Component/ObjectMapper/Tests/Fixtures/TransformCollection/A.php
Show resolved
Hide resolved
Co-authored-by: Jérôme Tamarelle <jerome@tamarelle.net>
OskarStark
reviewed
May 19, 2025
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
soyuka
commented
May 20, 2025
| throw new MappingException(sprintf('The MapCollection transform expects an iterable, "%s" given.', get_debug_type($value))); | ||
| } | ||
|
|
||
| foreach ($value as &$v) { |
There was a problem hiding this comment.
I think it'd be best to create a new array this is probably why psalm is not happy :P
There was a problem hiding this comment.
Indeed. Plus, if the iterator is not rewindable, the actual implementation can cause troubles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another approach to embeded collection mapping that avoids changing the ObjectMapper. Even if this doesn't land in the component it'd be a good thing to document. Let me know your thoughts.