[Security] Deprecate callable firewall listeners #60614
Open
+104
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
reviewed
Jun 1, 2025
chalasr
requested changes
Jun 1, 2025
f2b8c5e to
311c89f
Compare
Spomky
approved these changes
Jun 11, 2025
311c89f to
253ed34
Compare
chalasr
reviewed
Jun 11, 2025
| if (!$listener instanceof FirewallListenerInterface) { | ||
| trigger_deprecation('symfony/security-http', '7.4', 'Using a callable as firewall listener is deprecated, extend "%s" or implement "%s" instead.', AbstractListener::class, FirewallListenerInterface::class); | ||
| } | ||
|
|
||
| $listener($event); |
There was a problem hiding this comment.
is this still fine given __invoke() is not specified by FirewallListenerInterface? Has it ever been or should it be authenticate()? Just wondering as I feel like something's been lost in my memory
There was a problem hiding this comment.
For now every implementation of FirewallListenerInterface is supposed to extend the AbstractListener which makes it callable.
225e787 to
fd98438
Compare
|
Just noticed that the |
fd98438 to
2b96194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After spending some time in the Security component it occurred to me callable firewall listeners are obsolete now that we got the
FirewallListenerInterface. Their deprecation has already been suggested (like in #34627 (comment) or #38751 (review)), so this PR does it.