[ObjectMapper] Map a collection of objects #60615
Conversation
There was a problem hiding this comment.
Because this is a new feature, don't forget to add a line in the changelog of the component! Also, don't forget to check fabbot which will provide some automated feedback on the code style.
| } | ||
| } | ||
|
|
||
| if (!empty($exceptions)) { |
There was a problem hiding this comment.
We avoid using empty() in Symfony, this may be replaced by:
| if (!empty($exceptions)) { | |
| if ($exceptions) { |
| interface MapMultipleInterface | ||
| { | ||
| /** | ||
| * @template T of object |
There was a problem hiding this comment.
Should this annotation be on the class instead of the method, so devs can use @implements MapMultipleInterface<Something>? I'm not sure this works well if the template definition is on the method
|
|
||
| self::assertInstanceOf(D::class, $target[0]); | ||
| $firstTarget = $target[0]; | ||
| assert($firstTarget instanceof D); |
There was a problem hiding this comment.
We don't use assert(), also the instance is already checked above with self::assertInstanceOf(D::class, $target[0]);
| self::assertInstanceOf(D::class, $target[1]); | ||
| $secondTarget = $target[1]; | ||
| assert($secondTarget instanceof D); |
| self::assertEquals('foo2', $secondTarget->baz); | ||
| self::assertEquals('bar2', $secondTarget->bat); |
There was a problem hiding this comment.
We use self::assertSame wherever possible 🙂
|
|
||
| self::fail('Mapping of second source element should have thrown!'); | ||
| } catch (MapMultipleAggregateException $ex) { | ||
| self::assertEquals('Mapping source collection has failed.', $ex->getMessage()); |
There was a problem hiding this comment.
| self::assertEquals('Mapping source collection has failed.', $ex->getMessage()); | |
| self::assertSame('Mapping source collection has failed.', $ex->getMessage()); |
(Same for the occurrences below)
| self::assertCount(1, $target, 'Mapping first source collection object should have passed!'); | ||
| self::assertInstanceOf(D::class, $target[0]); | ||
| $firstTarget = $target[0]; | ||
| assert($firstTarget instanceof D); |
There was a problem hiding this comment.
Same as above, this is needed 🙂
Add functionality to map multiple source objects to the specified target type.
This is my 1st PR to Symfony. Looking forward to all kinds of feedback.