Skip to content

Bump Symfony 8 to PHP >= 8.4 #60639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jun 2, 2025

Q A
Branch? 8.0
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

Let's start this new major cycle with fresh features shipped with PHP 8.4: native lazy objects, HTML5 dom parser, etc.

For reference, this took inspiration from a similar PR for 7.0: #50404

Copy link
Member

@alexandre-daubois alexandre-daubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Neirda24
Copy link
Contributor

Neirda24 commented Jun 3, 2025

Awesome ! Would it be worth waiting for 8.5 for this kind of feature ? https://wiki.php.net/rfc/closures_in_const_expr It could be wild for some features. Otherwise it would have to wait 2 years for symfony 9 before including such functionnalities in core. I know that the timing is short because 8.5 is planned for November I think...

@stof
Copy link
Member

stof commented Jun 3, 2025

@Neirda24 We already support using static closures in some attributes in Symfony 7.3. We don't need to make PHP 8.5 the minimum supported version to benefit from those, as long as the usage of a closure is not required when using the attribute. For instance, IsGranted added support for using a static closure, but kept support for using an Expression (same for the When constraint).

And PHP 8.5.0 will be will be approximately at the same time than Symfony 8.0.0. This does not qualify it as a candidate for the min version, as it would make it too hard to upgrade to it (many companies don't upgrade their prod to the .0 release of PHP, to give it more time to stabilize with a few patch versions before they upgrade prod environments)

@nicolas-grekas nicolas-grekas force-pushed the php84 branch 2 times, most recently from 068e8eb to 2932863 Compare June 3, 2025 12:08
@nicolas-grekas nicolas-grekas merged commit 6251fbc into symfony:8.0 Jun 3, 2025
7 of 10 checks passed
@nicolas-grekas nicolas-grekas deleted the php84 branch June 3, 2025 12:36
@vinceAmstoutz
Copy link

🎉🔥

@garak
Copy link
Contributor

garak commented Jun 11, 2025

https://symfony.com/releases/8.0 still reports "8.2.0 or higher" as requirement tho

@kbond
Copy link
Member

kbond commented Jun 11, 2025

https://symfony.com/releases/8.0 still reports "8.2.0 or higher" as requirement tho

I think this is something @javiereguiluz can update.

@javiereguiluz
Copy link
Member

@garak @kbond this is now fixed. Thanks for reporting this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.