[Form] Fix handling the empty string in NumberToLocalizedStringTransformer #60676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d310abb to
9bf812e
Compare
...mponent/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
Outdated
Show resolved
Hide resolved
9bf812e to
eec5f2e
Compare
|
As an aside this is basically doing the other half of #37505 |
xabbuh
approved these changes
Jun 4, 2025
MatTheCat
reviewed
Jun 5, 2025
| @@ -50,7 +50,7 @@ public function __construct(?int $scale = null, ?bool $grouping = false, ?int $r | |||
| */ | |||
| public function transform(mixed $value): string | |||
| { | |||
| if (null === $value) { | |||
| if (null === $value || '' === $value) { | |||
There was a problem hiding this comment.
Shouldn’t $value PHPdoc be updated to include string?
|
Don't we need the same check in MoneyToLocalizedStringTransformer? |
eec5f2e to
f623d3a
Compare
|
I've pushed another version that includes changes to the docblock and identical changes to MoneyToLocalizedStringTransformer including a test (I didn't run them locally so will push an update if somehow I did it wrong). |
|
Thank you @gnat42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NumberToLocalizedStringTransformer only tests for null, but if the value is an empty string then the test for is_numeric fails. This change makes the reverseTransform and transform methods both test for null or empty strings