[Ldap][Security] Remove deprecated eraseCredentials() from (User|Token)Interface
#60742
+48
−245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eraseCredentials() from (User|Token)InterfaceeraseCredentials() from (User|Token)Interface
0edc0fd to
9127d07
Compare
9127d07 to
e1ed824
Compare
Fan2Shrek
approved these changes
Jun 9, 2025
alexandre-daubois
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't deprecate the config option + container parameter from SecurityBundle nor the corresponding
AuthenticatorManagerconstructor param, I propose to keep them no-op and deprecate them in 8.1 (mainly becauseAuthenticatorManageralready deprecates a boolean parameter in 7.3 which makes deprecating the parameter complicates the bc layer and upgrade path significantly).