[Validator] ConstraintViolationBuilder: fromViolation(), addViolation(), setPath() #60746
+98
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setPath(), getViolation()
|
Hi @rela589n To be honest, I'm not aware of the full discussion/previous proposal.
That would really help with the review. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @xabbuh , @nicolas-grekas
First of all, sorry for disruption, I didn't want to disturb you. I just wanted to ask for such simple feature.
Regarding the last message probably you didn't understand me correctly. I was asking how you would implement yourself if you needed it yourself? I mean if you needed it somewhere in the code, and there's a another component where validation returns violation object and in your component you need to adjust its path, parameters, etc. You would use the builder as this, wouldn't you?
Again, sorry for taking your time, I really appreciate you for being patient with me.