[Messenger] Allow handler locator to be set #60753
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbaldanza
commented
Jun 10, 2025
| { | ||
| $container = $this->getContainerBuilder($busId = 'message_bus'); | ||
|
|
||
| $container->register($busId. '.messenger.handlers_locator', \stdClass::class); |
There was a problem hiding this comment.
stdClass isn't the right class here but wasn't sure it was worth the effort to create a fake HandlersLocatorInterface but happy to add it if you would prefer
The `HandleMessageMiddleware` has a dependency on a `HandlersLocatorInterface` but this gets registered by the messenger pass. As far as I can see there isn't a way for an application to provide it's own implementation. By checking if the service already exists before registering then we can allow applications to define their own
fcff4ae to
8b63b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to use the
HandleMessageMiddlewarebut use a different locator to get the handlers of the messages. TheHandleMessageMiddlewareuses an interface but I can't see how to define a different implementation as the compiler pass sets this argument per bus.I could define my own version of the
handle_messagemiddleware and provide the dependancy but this means I can no longer use thedefault_middlewareconfiguration.By checking if the locator already exists it means the application could define the
HandlersLocatorInterfaceimplementation that is used by defining something like this in their services.yaml:{$busName}.messenger.handlers_locator: '@Application\Middleware\HandlersLocator'Would be great to hear if there's maybe a better way to do this or if I've missed a detail on how to provide the
HandlersLocatorInterface