[Messenger] Allow SQS to handle its own retry/DLQ #60754
Conversation
Allow SQS to handle retries rather then handling this by Symfony. This allows applications to use the retry strategy from SQS rather then Symfony. The default is for the message to be deleted from SQS at which point Symfony will handle the retry by deleting and then adding back in to the queue. If `delete_on_rejection` is set to `false` instead it will change the message visibility of the message on SQS and thus SQS to handle the retry mechanism
|
Hey! Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.4 for features". Cheers! Carsonbot |
| @@ -101,6 +102,7 @@ public function __destruct() | |||
| * * wait_time: long polling duration in seconds (Default: 20) | |||
| * * poll_timeout: amount of seconds the transport should wait for new message | |||
| * * visibility_timeout: amount of seconds the message won't be visible | |||
| * * delete_on_rejection: Whether to delete message on rejection or allow SQS to handle retries. (Default: true). If set to false then the `retry_strategy` should be set to `max_retries: 0` | |||
There was a problem hiding this comment.
Ideally we should throw an error if setting delete_on_rejection and the retry_strategy doesn't have max_retries set as 0 as this option should only be used if SQS is fully responsible for the retries/DLQ but we don't have access to that so was hoping documentation is enough to cover that.
Would love to hear thoughts here
Thanks Carsonbot I fixed the mistake |
Allow SQS to handle retries rather then handling this by Symfony.
This allows applications to use the retry strategy from SQS rather then Symfony.
The default is for the message to be deleted from SQS at which point Symfony
will handle the retry by then adding back in to the queue.
If
delete_on_rejectionis set tofalseinstead it will change the messagevisibility of the message on SQS and thus SQS to handle the retry mechanism
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-visibility-timeout.html
As mentioned on the linked issue this has a number of benefits but mainly