Skip to content

[FrameworkBundle] Fixes getting a type error when the secret you are trying to reveal could not be decrypted #60774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jack-worman
Copy link
Contributor

@jack-worman jack-worman commented Jun 12, 2025

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

Fixes getting a type error when the secret you are trying to reveal could not be decrypted.

In SymfonyStyle.php line 322:
                                                                                                                                                                                                                                    
  Symfony\Component\Console\Style\SymfonyStyle::writeln(): Argument #1 ($messages) must be of type Traversable|array|string, null given, called in /Users/jworman/PhpstormProjects/gtx/vendor/symfony/framework-bundle/Command/Sec  
  retsRevealCommand.php on line 67                                                                                                                                                                                                  
                                                                                                                                                                                                                                    

Not sure if this is considered a bug fix or a new feature

@carsonbot carsonbot added this to the 7.4 milestone Jun 12, 2025
@jack-worman jack-worman force-pushed the Fix-type-error-when-revealing-broken-secret branch 3 times, most recently from ba60013 to 1b950da Compare June 12, 2025 18:09
@carsonbot carsonbot changed the title Fix-type-error-when-revealing-broken-secret [FrameworkBundle] Fix-type-error-when-revealing-broken-secret Jun 13, 2025
@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] Fix-type-error-when-revealing-broken-secret [FrameworkBundle] Fixes getting a type error when the secret you are trying to reveal could not be decrypted Jun 15, 2025
@nicolas-grekas nicolas-grekas modified the milestones: 7.4, 6.4, 7.2 Jun 15, 2025
@nicolas-grekas nicolas-grekas changed the base branch from 7.4 to 7.2 June 15, 2025 09:49
@nicolas-grekas nicolas-grekas force-pushed the Fix-type-error-when-revealing-broken-secret branch from 1b950da to 480e7d1 Compare June 15, 2025 09:49
@nicolas-grekas
Copy link
Member

Thank you @jack-worman.

@nicolas-grekas nicolas-grekas merged commit dc05cb2 into symfony:7.2 Jun 15, 2025
3 of 11 checks passed
@jack-worman jack-worman deleted the Fix-type-error-when-revealing-broken-secret branch June 15, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants