[FrameworkBundle] Allow to un-verbose all the method in BrowserKitAssertionsTrait
#60788
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VincentLanglet
commented
Jun 13, 2025
| Q | A |
|---|---|
| Branch? | 7.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | Fix #... |
| License | MIT |
src/Symfony/Bundle/FrameworkBundle/Test/BrowserKitAssertionsTrait.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Jun 15, 2025
alexandre-daubois
approved these changes
Jun 16, 2025
Comment on lines
+38
to
43
| public static function assertResponseIsSuccessful(string $message = '', ?bool $verbose = null): void | ||
| { | ||
| $verbose ??= self::$defaultVerboseMode; | ||
|
|
||
| self::assertThatForResponse(new ResponseConstraint\ResponseIsSuccessful($verbose), $message); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public static function assertResponseIsSuccessful(string $message = '', ?bool $verbose = null): void | |
| { | |
| $verbose ??= self::$defaultVerboseMode; | |
| self::assertThatForResponse(new ResponseConstraint\ResponseIsSuccessful($verbose), $message); | |
| } | |
| public static function assertResponseIsSuccessful(string $message = '', ?bool $verbose = null): void | |
| { | |
| self::assertThatForResponse(new ResponseConstraint\ResponseIsSuccessful($verbose ?? self::$defaultVerboseMode), $message); | |
| } |
We could use this notation also to spare a potential assignment. Just a thought, the current code also suits me fine
BrowserKitAssertionsTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.