[Form] Add form type guesser for `EnumType` #61297

mttsch · 2025-08-01T15:55:31Z

Q	A
Branch?	7.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix #61272
License	MIT

This new form type guesser guesses the form type of an enum property and also sets the class option of the EnumType to the relevant enum name.

src/Symfony/Component/Form/EnumFormTypeGuesser.php

src/Symfony/Bundle/FrameworkBundle/Resources/config/form.php

nicolas-grekas · 2025-08-05T09:46:41Z

src/Symfony/Component/Form/Tests/Fixtures/EnumFormTypeGuesserCase.php

+
+namespace Symfony\Component\Form\Tests\Fixtures;
+
+final class EnumFormTypeGuesserCase


nicolas-grekas · 2025-08-05T09:47:09Z

src/Symfony/Component/Form/Tests/EnumFormTypeGuesserTest.php

+use Symfony\Component\Form\Tests\Fixtures\EnumFormTypeGuesserCase;
+use Symfony\Component\Form\Tests\Fixtures\EnumFormTypeGuesserCaseEnum;
+
+final class EnumFormTypeGuesserTest extends TestCase


final is pure visual overhead ;)

Suggested change

final class EnumFormTypeGuesserTest extends TestCase

class EnumFormTypeGuesserTest extends TestCase

src/Symfony/Component/Form/Tests/EnumFormTypeGuesserTest.php

nicolas-grekas · 2025-08-05T09:53:08Z

src/Symfony/Component/Form/EnumFormTypeGuesser.php

+
+final class EnumFormTypeGuesser implements FormTypeGuesserInterface
+{
+    private array $cache = [];


Suggested change

private array $cache = [];

/**

* @var (\ReflectionNamedType|false)[]

*/

private array $cache = [];

The suggested type is not correct, I used the correct one (nested array)

nicolas-grekas · 2025-08-05T09:53:28Z

src/Symfony/Component/Form/EnumFormTypeGuesser.php

+
+    public function guessType(string $class, string $property): ?TypeGuess
+    {
+        if (null === ($propertyType = $this->getPropertyType($class, $property))) {


Suggested change

if (null === ($propertyType = $this->getPropertyType($class, $property))) {

if (!$propertyType = $this->getPropertyType($class, $property)) {

nicolas-grekas · 2025-08-05T09:55:10Z

src/Symfony/Component/Form/EnumFormTypeGuesser.php

+
+    private function getPropertyType(string $class, string $property): ?\ReflectionNamedType
+    {
+        if (isset($this->cache[$class]) && \array_key_exists($property, $this->cache[$class])) {


Suggested change

if (isset($this->cache[$class]) && \array_key_exists($property, $this->cache[$class])) {

if (isset($this->cache[$class][$property])) {

nicolas-grekas · 2025-08-05T09:55:37Z

src/Symfony/Component/Form/EnumFormTypeGuesser.php

+        if (!isset($this->cache[$class])) {
+            $this->cache[$class] = [];
+        }
+


Suggested change

if (!isset($this->cache[$class])) {

$this->cache[$class] = [];

}

nicolas-grekas · 2025-08-05T09:55:52Z

src/Symfony/Component/Form/EnumFormTypeGuesser.php

+            $classReflection = new \ReflectionClass($class);
+            $propertyReflection = $classReflection->getProperty($property);
+        } catch (\ReflectionException) {
+            return $this->cache[$class][$property] = null;


Suggested change

return $this->cache[$class][$property] = null;

return $this->cache[$class][$property] = false;

nicolas-grekas · 2025-08-05T09:56:41Z

src/Symfony/Component/Form/EnumFormTypeGuesser.php

+            $classReflection = new \ReflectionClass($class);
+            $propertyReflection = $classReflection->getProperty($property);


Suggested change

$classReflection = new \ReflectionClass($class);

$propertyReflection = $classReflection->getProperty($property);

$propertyReflection = new \ReflectionProperty($class, $property);

nicolas-grekas · 2025-08-05T09:58:57Z

src/Symfony/Component/Form/EnumFormTypeGuesser.php

+        if (!$propertyReflection->getType() instanceof \ReflectionNamedType || !enum_exists($propertyReflection->getType()->getName())) {
+            return $this->cache[$class][$property] = null;
+        }
+
+        return $this->cache[$class][$property] = $propertyReflection->getType();


Suggested change

if (!$propertyReflection->getType() instanceof \ReflectionNamedType || !enum_exists($propertyReflection->getType()->getName())) {

return $this->cache[$class][$property] = null;

}

return $this->cache[$class][$property] = $propertyReflection->getType();

$type = $propertyReflection->getType();

if (!$type instanceof \ReflectionNamedType || !enum_exists($enum->getName())) {

$type = false;

}

return $this->cache[$class][$property] = $type;

xabbuh · 2025-08-05T20:29:00Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

@@ -564,6 +565,10 @@ public function load(array $configs, ContainerBuilder $container): void
            if (!$this->readConfigEnabled('html_sanitizer', $container, $config['html_sanitizer']) || !class_exists(TextTypeHtmlSanitizerExtension::class)) {
                $container->removeDefinition('form.type_extension.form.html_sanitizer');
            }
+
+            if (!class_exists(EnumFormTypeGuesser::class)) {


I would do this inside registerFormConfiguration()

src/Symfony/Component/Form/EnumFormTypeGuesser.php

xabbuh · 2025-08-05T20:31:37Z

src/Symfony/Component/Form/EnumFormTypeGuesser.php

+
+namespace Symfony\Component\Form;
+
+use Symfony\Component\Form\Extension\Core\Type\EnumType as FormEnumType;


Suggested change

use Symfony\Component\Form\Extension\Core\Type\EnumType as FormEnumType;

use Symfony\Component\Form\Extension\Core\Type\EnumType;

I don't see why we need the alias here

Done. (Was previously needed because EnumType from symfony/type-info was also used.)

mttsch requested review from xabbuh and yceruto as code owners August 1, 2025 15:55

carsonbot added Status: Needs Review Feature Form labels Aug 1, 2025

carsonbot added this to the 7.4 milestone Aug 1, 2025

mttsch commented Aug 1, 2025

View reviewed changes

src/Symfony/Component/Form/EnumFormTypeGuesser.php Outdated Show resolved Hide resolved

mttsch force-pushed the feature/61272-form-enum-type-guesser branch 4 times, most recently from 30ce63c to 0796aa4 Compare August 1, 2025 16:27

This comment was marked as outdated.

Sign in to view

mttsch force-pushed the feature/61272-form-enum-type-guesser branch 2 times, most recently from 80d176c to 78a2346 Compare August 3, 2025 03:40

nicolas-grekas reviewed Aug 5, 2025

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Resources/config/form.php Show resolved Hide resolved

mttsch force-pushed the feature/61272-form-enum-type-guesser branch 2 times, most recently from 1fbb523 to a5eebb2 Compare August 5, 2025 09:53

nicolas-grekas reviewed Aug 5, 2025

View reviewed changes

mttsch force-pushed the feature/61272-form-enum-type-guesser branch from a5eebb2 to 1e540eb Compare August 5, 2025 14:51

xabbuh reviewed Aug 5, 2025

View reviewed changes

src/Symfony/Component/Form/EnumFormTypeGuesser.php Show resolved Hide resolved

xabbuh reviewed Aug 5, 2025

View reviewed changes

[Form] Add form type guesser for EnumType

dc492c9

mttsch force-pushed the feature/61272-form-enum-type-guesser branch from 1e540eb to dc492c9 Compare August 6, 2025 03:28


		namespace Symfony\Component\Form\Tests\Fixtures;

		final class EnumFormTypeGuesserCase

	final class EnumFormTypeGuesserTest extends TestCase
	class EnumFormTypeGuesserTest extends TestCase

	if (null === ($propertyType = $this->getPropertyType($class, $property))) {
	if (!$propertyType = $this->getPropertyType($class, $property)) {

	if (isset($this->cache[$class]) && \array_key_exists($property, $this->cache[$class])) {
	if (isset($this->cache[$class][$property])) {

	if (!isset($this->cache[$class])) {
	$this->cache[$class] = [];
	}

	return $this->cache[$class][$property] = null;
	return $this->cache[$class][$property] = false;

		$classReflection = new \ReflectionClass($class);
		$propertyReflection = $classReflection->getProperty($property);

	$classReflection = new \ReflectionClass($class);
	$propertyReflection = $classReflection->getProperty($property);
	$propertyReflection = new \ReflectionProperty($class, $property);

-        if (!$propertyReflection->getType() instanceof \ReflectionNamedType || !enum_exists($propertyReflection->getType()->getName())) {
-            return $this->cache[$class][$property] = null;
-        }
-        return $this->cache[$class][$property] = $propertyReflection->getType();
+        $type = $propertyReflection->getType();
+        if (!$type instanceof \ReflectionNamedType || !enum_exists($enum->getName())) {
+            $type = false;
+        }
+        return $this->cache[$class][$property] = $type;


		namespace Symfony\Component\Form;

		use Symfony\Component\Form\Extension\Core\Type\EnumType as FormEnumType;

Uh oh!

[Form] Add form type guesser for EnumType #61297

Are you sure you want to change the base?

[Form] Add form type guesser for EnumType #61297

Uh oh!

Conversation

mttsch commented Aug 1, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

[Form] Add form type guesser for `EnumType` #61297

[Form] Add form type guesser for `EnumType` #61297