[Console] Fix name/alias/usages when an invokable command has an alias #61367
+15
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Aug 13, 2025
GromNaN
reviewed
Aug 14, 2025
Comment on lines
162
to
164
| if (\is_callable($this) && self::class === (new \ReflectionMethod($this, 'execute'))->getDeclaringClass()->name) { | ||
| $this->code = new InvokableCommand($this, $this(...)); | ||
| } |
There was a problem hiding this comment.
This lines are here to support invokable classes that extend the Command class. This is a supported feature, see InvokableCommandTest::testCallInvokeMethodWhenExtendingCommandClass that is now failing.
I would add if (!$code && ... to the condition.
GromNaN
reviewed
Aug 14, 2025
Comment on lines
2302
to
2316
| #[RequiresPhpExtension('pcntl')] | ||
| public function testSignalableInvokableCommandThatExtendsBaseCommand() | ||
| { | ||
| $command = new class extends Command implements SignalableCommandInterface { | ||
| use SignalableInvokableCommandTrait; | ||
| }; | ||
| $command->setName('signal-invokable'); | ||
|
|
||
| $application = $this->createSignalableApplication($command, null); | ||
| $application->setSignalsToDispatchEvent(\SIGUSR1); | ||
|
|
||
| $this->assertSame(1, $application->run(new ArrayInput(['signal-invokable']))); | ||
| $this->assertTrue($command->signaled); | ||
| } | ||
|
|
There was a problem hiding this comment.
This test is not related to the fix. This change should be reverted.
GromNaN
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invokable commands don't construct their command name properly when an alias is present. This makes the command uncallable. The name has a pipe and alias appended such as
example:name | my-alias. This appending is done by#[AsCommand]. You can see the effect by looking the test failure in the first commit to this PR.The PR fixes the issue by removing a
returnwhen handling of invokables in Command::__construct(). We can mostly use same logic as non-invokables.I discovered this while moving Drush (Drupal's CLI) to invokable commands.