Skip to content

[DependencyInjection] Don’t autowire excluded services #61411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

[DependencyInjection] Don’t autowire excluded services #61411

merged 1 commit into from
Aug 15, 2025
+17 −10

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60738
License MIT

@MatTheCat MatTheCat requested a review from dunglas as a code owner August 14, 2025 09:15
@carsonbot carsonbot added this to the 7.4 milestone Aug 14, 2025
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.4" but it seems your PR description refers to branch "7.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@MatTheCat MatTheCat changed the base branch from 7.4 to 7.3 August 14, 2025 09:15
GromNaN
GromNaN reviewed Aug 14, 2025
View reviewed changes
@nicolas-grekas nicolas-grekas modified the milestones: 7.4, 7.3 Aug 15, 2025
@nicolas-grekas
Copy link
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit dff83bc into symfony:7.3 Aug 15, 2025
9 of 11 checks passed
@MatTheCat MatTheCat deleted the ticket_60738 branch August 15, 2025 12:08
@MatTheCat MatTheCat mentioned this pull request Aug 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

Enums are considered as services by the container
6 participants
@MatTheCat @carsonbot @nicolas-grekas @GromNaN @OskarStark @xabbuh