Skip to content

[Validator] Fix parameters list in Choice::$multipleMessage option #21079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

niconoe-
Copy link
Contributor

@niconoe- niconoe- commented Jun 13, 2025

Documentation says that \Symfony\Component\Validator\Constraints\Choice::$multipleMessage option can take parameters {{ value }} and {{ label }} in the message, but regarding \Symfony\Component\Validator\Constraints\ChoiceValidator, this is wrong. Just like for the other use-cass of Choice messaging options, it cannot take {{ label }} but {{ choices }} instead.

@xabbuh xabbuh added this to the 6.4 milestone Jun 13, 2025
@niconoe-
Copy link
Contributor Author

Sorry, someone noticed me that also {{ limit }} parameter is not explained for the minMessage and maxMessage option. I added them.

@carsonbot carsonbot changed the title Fix parameters list in Choice::$multipleMessage option [Validator] Fix parameters list in Choice::$multipleMessage option Jun 13, 2025
@javiereguiluz javiereguiluz changed the base branch from 7.3 to 6.4 June 13, 2025 13:17
@javiereguiluz
Copy link
Member

Good catch Nicolas! Thanks ... and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit d852a55 into symfony:6.4 Jun 13, 2025
3 checks passed
@niconoe- niconoe- deleted the patch-1 branch June 13, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants