Skip to content

Clarify renaming arguments isn't generally covered by the BC promise #21288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 7.3
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions contributing/code/bc.rst
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ Make final No
Move to parent class Yes
:ref:`Add argument without a default value <add-argument-public-method>` No
:ref:`Add argument with a default value <add-argument-public-method>` No :ref:`[7] <note-7>` :ref:`[8] <note-8>`
Rename argument Yes :ref:`[10] <note-10>`
Remove argument No :ref:`[3] <note-3>`
Add default value to an argument No :ref:`[7] <note-7>` :ref:`[8] <note-8>`
Remove default value of an argument No
Expand All @@ -304,6 +305,7 @@ Make public No
Move to parent class Yes
:ref:`Add argument without a default value <add-argument-public-method>` No
:ref:`Add argument with a default value <add-argument-public-method>` No :ref:`[7] <note-7>` :ref:`[8] <note-8>`
Rename argument Yes :ref:`[10] <note-10>`
Remove argument No :ref:`[3] <note-3>`
Add default value to an argument No :ref:`[7] <note-7>` :ref:`[8] <note-8>`
Remove default value of an argument No :ref:`[7] <note-7>`
Expand All @@ -320,6 +322,7 @@ Change name Yes
Make public or protected Yes
Add argument without a default value Yes
Add argument with a default value Yes
Rename argument Yes
Remove argument Yes
Add default value to an argument Yes
Remove default value of an argument Yes
Expand Down