Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #2354, I decided to dive deeper and found the culprit. The issue happens, when adjusting the visible range of an axis via RangeController and leaving one side as is. In that case, the visible range is updated to the actual min/max for the side that should remain equal.
As far as I understood the source code: _updateZoomFactorAndPosition gets the updated min and max as input. If a value does not change, it is given as null. Based on the new values, the new zoom factor and position are determined. In the current implementation, the fallback for null, i.e., nothing should change, is the actual min/max, leading to the visible range jumping to 2000 in the example from the issue. As the zoom is based on the visible range, that should be used as fallback instead, which is what I did in this PR.
I tried my best, but I'm still foreign to your personal coding practices, so feel free to remark anything and I will adjust the code accordingly.