Skip to content

currentScript hook to try document.currentScript before lastScript #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

currentScript hook to try document.currentScript before lastScript #2469

wants to merge 1 commit into from

Conversation

jchip
Copy link

@jchip jchip commented Sep 13, 2023

fix #2465

Adds a hook function getCurrentScript that try document.currentScript before getting the lastScript.

@github-actions
Copy link

File size impact

Merging main into main will impact 2 files in 1 group.

browser (2/2)
File raw gzip brotli Event
dist/s.min.js +124 (8,006) +37 (3,161) +36 (2,868) modified
dist/system.min.js +124 (12,344) +36 (4,758) +24 (4,285) modified
Total size impact +248 (20,350) +73 (7,919) +60 (7,153)
node (0/1)

No impact on files in node group.

extras (0/8)

No impact on files in extras group.

Generated by file size impact during size-impact#6178313082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lastScript detection doesn't seem to be 100% reliable
1 participant
@jchip