Fix TLA: module should wait for its async dependencies #2488
Conversation
File size impactMerging kz/top-level-await-fix into main will impact 3 files in 2 groups. browser (2/2)
node (1/1)
extras (0/8)No impact on files in extras group. |
There was a problem hiding this comment.
Thank you so much for looking into this. Because this is a very complex algorithm, I think just having one test case is not enough to prove we aren't introducing other regressions.
For better testing I would advise looking at cases from the TLA fuzzer at https://github.com/evanw/tla-fuzzer, and trying to incorporate some more and show that this overall improves conformance over degraging it.
| if (!process.env.SYSTEM_PRODUCTION) triggerOnload(loader, load, load.er, true); | ||
| triggerOnload(loader, load, load.er, true); |
There was a problem hiding this comment.
The onload event is only for the non-production build.
|
|
||
| return doExec(); | ||
| if (depLoadPromises) { | ||
| return load.E = Promise.all(depLoadPromises).then(doExec).finally(function() { |
There was a problem hiding this comment.
This is quite a big algorithmic change, that will likely have repercussions. I think to be comfortable making these kinds of algorithmic changes it would help to see much more test cases being checked.
|
I've also pushed a change to main to fix the broken CI. |
Reopening #2402 since the case is still valid.
Addresses: #2473
Here's the test results without the changes applied:
