Skip to content

[mlir][tosa] Update rounding mode, nan propagation and resize mode to enums #99500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[mlir][tosa] Update rounding mode, nan propagation and resize mode to enums #99500

wants to merge 1 commit into from

Conversation

lhutton1
Copy link
Contributor

Aligns with LLVM updates to convert string attributes to enums.

@lhutton1
[mlir][tosa] Update rounding mode, nan propagation and resize mode to…
135e067 
… enums

Aligns with LLVM updates to convert string attributes to enums.

Change-Id: I99bc0634b0c7700e10e362986a23c003a18d6b40
@google-ml-butler google-ml-butler bot added the size:L CL Change Size: Large label Aug 28, 2025
@lhutton1
Copy link
Contributor Author

lhutton1 commented Aug 28, 2025 •
edited
Loading

This PR aligns with the proposed updates to TOSA enums in llvm/llvm-project#152856 followed by llvm/llvm-project#155695 - please wait till these changes are merged and consumed by tensorflow.

Tests:

INFO: Build completed successfully, 16 total actions
//tensorflow/compiler/mlir/tosa/tests:convert_metadata.mlir.test (cached) PASSED in 0.4s
//tensorflow/compiler/mlir/tosa/tests:tf-unequal-ranks.mlir.test (cached) PASSED in 0.8s
//tensorflow/compiler/mlir/tosa/tests:tfl-unequal-ranks.mlir.test (cached) PASSED in 0.7s
//tensorflow/compiler/mlir/tosa/tests:convert-tfl-uint8.mlir.test        PASSED in 0.3s
//tensorflow/compiler/mlir/tosa/tests:fuse-bias-tf.mlir.test             PASSED in 0.4s
//tensorflow/compiler/mlir/tosa/tests:lower-complex-types.mlir.test      PASSED in 0.4s
//tensorflow/compiler/mlir/tosa/tests:multi_add.mlir.test                PASSED in 0.4s
//tensorflow/compiler/mlir/tosa/tests:retain_call_once_funcs.mlir.test   PASSED in 0.3s
//tensorflow/compiler/mlir/tosa/tests:strip-quant-types.mlir.test        PASSED in 0.3s
//tensorflow/compiler/mlir/tosa/tests:strip_metadata.mlir.test           PASSED in 0.3s
//tensorflow/compiler/mlir/tosa/tests:tf-tfl-to-tosa-pipeline.mlir.test  PASSED in 0.4s
//tensorflow/compiler/mlir/tosa/tests:tf-to-tosa-pipeline.mlir.test      PASSED in 0.7s
//tensorflow/compiler/mlir/tosa/tests:tfl-to-tosa-dequantize_softmax.mlir.test PASSED in 0.3s
//tensorflow/compiler/mlir/tosa/tests:tfl-to-tosa-pipeline-filtered.mlir.test PASSED in 0.4s
//tensorflow/compiler/mlir/tosa/tests:tfl-to-tosa-pipeline.mlir.test     PASSED in 3.8s
//tensorflow/compiler/mlir/tosa/tests:tfl-to-tosa-stateful.mlir.test     PASSED in 0.5s
//tensorflow/compiler/mlir/tosa/tests:verify_fully_converted.mlir.test   PASSED in 0.4s

@lhutton1
Copy link
Contributor Author

cc @Tai78641 @leandron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gbaned gbaned

Labels
size:L CL Change Size: Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhutton1 @gbaned