createEvent: Only run dataTransfer workarounds in jsdom environments #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build failure is dealt with in #1346 |
6f8117e to
71fbd54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes for browser based environments, not present when used with jest/jsdom.
Why:
createEvent has a workaround for missing event.dataTransfer objects as they don't exist in jsdom environments like jest #585 . Browser-based environments will have native DataTransfer objects and that should be used as the tests may rely on them being the real thing.
How:
A simple check to see if the workaround is needed.
Checklist:
docs site