-
-
Notifications
You must be signed in to change notification settings - Fork 111
Finer custom fields match #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
With pgonly="1" <txp:article_custom /> will output the number of matching articles pages, without setting the pagination.
It seems already been attempts to add |
Sure, including mine, few years ago :-) It didn't get much attention, but I'm not desperate. The aim is to be able to easily count pages or articles (with |
The initial patch (enable pages count for article_custom) is merged into dev now. The rest of this branch allows for finer custom fields match in article(_custom) and related_articles. |
Although I haven't tested it, this seems like a pretty good idea to me. Is it okay to be merged? Any backwards-compatibility issues? Regarding the item attribute: it assumes comma is the separator. But an earlier commit references pipe also. Should we introduce a |
Thanks @Bloke. I thought we should postpone it to the unlimited custom fields era, also because |
bumping readme to have parity with `dev`
tweak top matter
Paging @bloatware – what's the status of this branch / PR from your viewpoint? The branch reports as 20 commits ahead of |
@petecooper this branch will be superseded by cf, so eventually including it in dev is only worth considering if dev and cf will not merge in a near future. But I hope they will and would keep this one aside. |
Thanks @bloatware – makes perfect sense. |
readme parity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @petecooper, will merge after 4.8.8 freeze.
With pgonly="1" <txp:article_custom /> will output the number of matching articles pages, without setting the pagination.