Update snapshot documentation to be clearer (address #118) #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuagl
reviewed
Jan 3, 2025
Comment on lines
+104
to
+105
| The snapshot.json metadata file lists version numbers and/or hashes of all of the targets | ||
| metadata. This file ensures that clients will see a consistent |
There was a problem hiding this comment.
Suggested change
| The snapshot.json metadata file lists version numbers and/or hashes of all of the targets | |
| metadata. This file ensures that clients will see a consistent | |
| The snapshot.json metadata file lists version numbers and/or hashes of all of | |
| the targets metadata files. This file ensures that clients will see a consistent |
Minor nit, but should we continue to refer to "metadata files" here?
|
superseded by #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.