Fix: prevent crash when stdoutRing or stderrRing is undefined by @decompi #3
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork from: fluent-ffmpeg#1321 by @decompi
This pull request fixes a bug that causes fluent-ffmpeg to crash when stdoutRing or stderrRing are undefined which happens when FFmpeg exits early or fails to spawn properly.
Problem:
In some rare cases (see fluent-ffmpeg#1316 ), the following error occurs:
TypeError: Cannot read properties of undefined (reading 'get')
at emitEnd (.../lib/processor.js:543:37)
This indicates stdoutRing or stderrRing may have not been initialized in time
My Patch:
Adds a null-safe check using stdoutRing?.get?.() and fallback to null if undefined.
Logs a warning when either ring is unexpectedly missing
Changed Lines:
Line 470 (timeout handler)
Line 502(output stream err handler)
Line 550 (final endCB cleanup)