Do not expose change in createCompilerHost

sheetalkamat · sheetalkamat · commit 4193846108b7 · 2018-08-21T14:46:00.000-07:00
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -66,7 +66,12 @@ namespace ts {
         mtime: Date;
     }
 
-    export function createCompilerHost(options: CompilerOptions, setParentNodes?: boolean, system = sys): CompilerHost {
+    export function createCompilerHost(options: CompilerOptions, setParentNodes?: boolean): CompilerHost {
+        return createCompilerHostWorker(options, setParentNodes);
+    }
+    /*@internal*/
+    // TODO(shkamat): update this after reworking ts build API
+    export function createCompilerHostWorker(options: CompilerOptions, setParentNodes?: boolean, system = sys): CompilerHost {
         const existingDirectories = createMap<boolean>();
 
         function getCanonicalFileName(fileName: string): string {
diff --git a/src/compiler/tsbuild.ts b/src/compiler/tsbuild.ts
@@ -413,7 +413,7 @@ namespace ts {
     }
 
     export function createSolutionBuilderHost(system = sys, reportDiagnostic?: DiagnosticReporter, reportSolutionBuilderStatus?: DiagnosticReporter) {
-        const host = createCompilerHost({}, /*setParentNodes*/ undefined, system) as SolutionBuilderHost;
+        const host = createCompilerHostWorker({}, /*setParentNodes*/ undefined, system) as SolutionBuilderHost;
         host.getModifiedTime = system.getModifiedTime ? path => system.getModifiedTime!(path) : () => undefined;
         host.setModifiedTime = system.setModifiedTime ? (path, date) => system.setModifiedTime!(path, date) : noop;
         host.deleteFile = system.deleteFile ? path => system.deleteFile!(path) : noop;
diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts
@@ -4122,7 +4122,7 @@ declare namespace ts {
 declare namespace ts {
     function findConfigFile(searchPath: string, fileExists: (fileName: string) => boolean, configName?: string): string | undefined;
     function resolveTripleslashReference(moduleName: string, containingFile: string): string;
-    function createCompilerHost(options: CompilerOptions, setParentNodes?: boolean, system?: System): CompilerHost;
+    function createCompilerHost(options: CompilerOptions, setParentNodes?: boolean): CompilerHost;
     function getPreEmitDiagnostics(program: Program, sourceFile?: SourceFile, cancellationToken?: CancellationToken): Diagnostic[];
     interface FormatDiagnosticsHost {
         getCurrentDirectory(): string;
diff --git a/tests/baselines/reference/api/typescript.d.ts b/tests/baselines/reference/api/typescript.d.ts
@@ -4122,7 +4122,7 @@ declare namespace ts {
 declare namespace ts {
     function findConfigFile(searchPath: string, fileExists: (fileName: string) => boolean, configName?: string): string | undefined;
     function resolveTripleslashReference(moduleName: string, containingFile: string): string;
-    function createCompilerHost(options: CompilerOptions, setParentNodes?: boolean, system?: System): CompilerHost;
+    function createCompilerHost(options: CompilerOptions, setParentNodes?: boolean): CompilerHost;
     function getPreEmitDiagnostics(program: Program, sourceFile?: SourceFile, cancellationToken?: CancellationToken): Diagnostic[];
     interface FormatDiagnosticsHost {
         getCurrentDirectory(): string;

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ namespace ts {`
`413`	`413`	`}`
`414`	`414`
`415`	`415`	`export function createSolutionBuilderHost(system = sys, reportDiagnostic?: DiagnosticReporter, reportSolutionBuilderStatus?: DiagnosticReporter) {`
`416`		`- const host = createCompilerHost({}, /setParentNodes/ undefined, system) as SolutionBuilderHost;`
	`416`	`+ const host = createCompilerHostWorker({}, /setParentNodes/ undefined, system) as SolutionBuilderHost;`
`417`	`417`	`host.getModifiedTime = system.getModifiedTime ? path => system.getModifiedTime!(path) : () => undefined;`
`418`	`418`	`host.setModifiedTime = system.setModifiedTime ? (path, date) => system.setModifiedTime!(path, date) : noop;`
`419`	`419`	`host.deleteFile = system.deleteFile ? path => system.deleteFile!(path) : noop;`