Skip to content

Repo: lint-fix script is broken #11201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fisker opened this issue May 11, 2025 · 3 comments
Open

Repo: lint-fix script is broken #11201

fisker opened this issue May 11, 2025 · 3 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@fisker
Copy link
Contributor

fisker commented May 11, 2025

Suggestion

I don't think pass --fix to

typescript-eslint/package.json

Line 41 in e57126a

"lint": "npx nx lint eslint-plugin --skip-nx-cache && npx nx run-many --target=lint --exclude eslint-plugin",

is correct.

Additional Info

No response
@fisker fisker added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels May 11, 2025
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels May 12, 2025
@JoshuaKGoldberg
Copy link
Member

Nice spot, thanks 🙂

@cseas
Copy link
Contributor

cseas commented Jun 10, 2025 •
edited
Loading

Hi! I tried looking into this.
It looks like the lint script isn't configured properly either. The lint command at the root package.json runs the below Nx target:

https://github.com/typescript-eslint/typescript-eslint/blob/main/package.json#L155-L156

This means the root lint script isn't linting any code inside packages. Is this intended?

I tried removing that packages filter and then got one ESLint error inside the packages directory. This is present on the main branch so I'm guessing the lint workflow isn't catching this either.

lint error message inside packages

The lint-fix script has changed since this issue was reported and now seems to be passing the --fix flag correctly. But I believe the behaviour of the lint script itself has now changed (modified in #11226).

Are the root lint and lint-fix scripts supposed to lint/fix the entire project or everything except packages?

@github-actions GitHub Actions
Copy link

Uh oh! @cseas, at least one image you shared is missing helpful alt text. Check #11201 (comment) to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 10

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fisker @JoshuaKGoldberg @cseas