Skip to content

Repo: Per-job CI Install step takes a minute #11205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue May 12, 2025 · 4 comments
Closed

Repo: Per-job CI Install step takes a minute #11205

JoshuaKGoldberg opened this issue May 12, 2025 · 4 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. performance Issues regarding performance repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Splitting out of #11204: right now, each CI job typically spends over a minute in the Install step:

typescript-eslint/.github/workflows/ci.yml

Line 58 in f8db925

uses: ./.github/actions/prepare-install

Examples from a docs-only PR, #11200:

That seems very long to me. In theory this should all be cached nicely, so all CI needs to do is download a lockfile and run a bit of disk linking/processing. Why does this take a full minute? Can we speed it up?

Additional Info

💖
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look performance Issues regarding performance repo maintenance things to do with maintenance of the repo, and not with code/docs labels May 12, 2025
This was referenced May 12, 2025
Open
Open
@maschwenk
Copy link
Contributor

Image

fwiw looks like almost all of that is in the link step

@github-actions GitHub Actions
Copy link

Uh oh! @maschwenk, at least one image you shared is missing helpful alt text. Check #11205 (comment) to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 1

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@kirkwaiblinger
Copy link
Member

Guessing that's because of the postinstall build?

@kirkwaiblinger kirkwaiblinger mentioned this issue May 14, 2025
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels May 19, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue May 19, 2025
Open
@kirkwaiblinger
Copy link
Member

After the merging of #11219, the install step is only taking about 15s. See CI logs on main: https://github.com/typescript-eslint/typescript-eslint/actions/runs/15326909449

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jun 6, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. performance Issues regarding performance repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maschwenk @JoshuaKGoldberg @kirkwaiblinger