chore: use TLA in ESM scripts rather than async main().catch() #11218
Conversation
|
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 069c83f.
☁️ Nx Cloud last updated this comment at |
| import { markdownTable } from 'markdown-table'; | ||
|
|
||
| async function main(): Promise<void> { | ||
| const rulesImport = await import('../src/rules/index.js'); |
There was a problem hiding this comment.
I also took the liberty of turning this into a static import since... it seems like we can just turn it into a static import and get better typing? But I can revert that if that's wrong.
There was a problem hiding this comment.
I don't remember why we kept this as a dynamic import 🤔 🤷
PR Checklist
Overview
Be sure to use "hide whitespace"