Skip to content

chore: remove postinstall steps from CI to speed up prepare-install action #11219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2025
+4 −2
Merged

chore: remove postinstall steps from CI to speed up prepare-install action #11219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba5a5cf
remove postinstall steps from CI
kirkwaiblinger May 14, 2025
a09d2b7
add generate-configs requirement
kirkwaiblinger May 14, 2025
ea54215
add repo:lint deps
kirkwaiblinger May 14, 2025
4e575ae
Merge branch 'main' into ci-speedup
kirkwaiblinger May 28, 2025
abe8c0e
linting depends on builds
kirkwaiblinger May 28, 2025
1fb95d6
use nx task to generate configs
kirkwaiblinger May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/prepare-install/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,4 @@ runs:
YARN_INSTALL_STATE_PATH: .yarn/ci-cache/install-state.gz # Very small speedup when lock does not change
# Other environment variables
HUSKY: '0' # By default do not run HUSKY install
SKIP_POSTINSTALL: 'true'
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
uses: ./.github/actions/prepare-install
with:
node-version: ${{ env.PRIMARY_NODE_VERSION }}
- run: yarn generate-configs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directly running yarn generate-configs seems to execute the yarn script directly, ignoring the dependsOn. So, I think yarn nx run generate-configs executes the nx task instead, which includes the necessary dependsOn.

- run: yarn nx run generate-configs
- run: git status --porcelain
- if: failure()
run: echo "Outdated result detected from yarn generate-configs. Please check in any file changes."
Expand Down
3 changes: 2 additions & 1 deletion packages/types/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"dependsOn": ["copy-ast-spec"]
},
"lint": {
"executor": "@nx/eslint:lint"
"executor": "@nx/eslint:lint",
"dependsOn": ["typescript-eslint:build", "eslint-plugin-internal:build"]
}
}
}
Loading